Skip to content

Feat/converter : Validation de la présence de la ressource RS-SR dans le RS-RI lors de la conversion#394

Merged
issam71100 merged 4 commits into
converter/rc-ri-single-messagefrom
feat/converter/validate-rs-sr-resource-in-rs-ri
Apr 16, 2026
Merged

Feat/converter : Validation de la présence de la ressource RS-SR dans le RS-RI lors de la conversion#394
issam71100 merged 4 commits into
converter/rc-ri-single-messagefrom
feat/converter/validate-rs-sr-resource-in-rs-ri

Conversation

@issam71100
Copy link
Copy Markdown
Contributor

@issam71100 issam71100 commented Apr 9, 2026 •
edited
Loading

🔎 Détails

Ajout d’une validation lors de la conversion : lorsqu’un RS-SR est reçu, la ressource référencée doit exister dans le RS-RI correspondant, sinon une erreur explicite est retournée.

📄 Documentation

Ajoutez un (des) lien(s) vers la documentation si nécessaire

📸 Captures d'écran

Avant Après

🔗 Ticket associé

A la réception d’un RS-SR, si la ressource n’est pas dans le RS-RI trouvé, retourner une erreur.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
constants.py40100% 
conversion_mixin.py29196%26
converter.py67395%26, 94–95
database.py322231%12, 16, 18–21, 23, 25, 27, 29–38, 40–41, 49
logging_config.py35294%29, 36
utils.py164398%57, 108, 120
cisu
   base_cisu_converter.py33390%7, 25, 31
   constants.py40100% 
   identical_cisu_converter.py90100% 
   utils.py150100% 
cisu/create_case
   create_case_cisu_constants.py310100% 
   create_case_cisu_converter.py145199%112
cisu/reference
   reference_converter.py9277%9, 13
cisu/resources_info
   resources_info_cisu_constants.py100100% 
   resources_info_cisu_converter.py155298%157, 318
   resources_info_cisu_helper.py37391%58, 63, 66
cisu/resources_status
   resources_status_constants.py40100% 
   resources_status_converter.py41197%33
conversion_strategy
   cisu_conversion_strategy.py49295%68, 93
   conversion_strategy.py70100% 
   health_conversion_strategy.py460100% 
models
   persisted_message.py130100% 
repositories
   message_repository.py701282%90–91, 98, 118–120, 122–123, 125, 171–173
versions
   base_message_converter.py831285%13, 72–74, 86, 98, 102, 106, 110, 114, 118, 124
   error_converter.py5180%7
   identical_message_converter.py150100% 
   utils.py26580%34–37, 43
versions/create_case_health
   constants.py40100% 
   create_case_health_converter.py1780100% 
   create_case_health_update_converter.py50100% 
versions/create_case_health/v1_v2
   constants.py170100% 
   utils.py460100% 
versions/create_case_health/v2_v3
   constants.py290100% 
versions/geo_positions_update
   geo_positions_update_constants.py40100% 
   geo_positions_update_converter.py49393%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py40100% 
   geo_resources_details_converter.py270100% 
versions/reference
   reference_constants.py20100% 
   reference_converter.py130100% 
versions/resources_engagement
   resources_engagement_constants.py30100% 
   resources_engagement_converter.py220100% 
versions/resources_info
   resources_info_constants.py200100% 
   resources_info_converter.py870100% 
versions/resources_request
   resources_request_constants.py20100% 
   resources_request_converter.py210100% 
versions/resources_response
   resources_response_constants.py40100% 
   resources_response_converter.py160100% 
versions/resources_status
   resources_status_constants.py100100% 
   resources_status_converter.py390100% 
TOTAL17407895% 

@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from 678fc5d to 07af75d Compare April 10, 2026 13:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from 07af75d to 1a1bbdf Compare April 10, 2026 14:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from 1a1bbdf to ec50d2b Compare April 10, 2026 15:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@issam71100 issam71100 marked this pull request as ready for review April 10, 2026 15:20
@issam71100 issam71100 changed the title Feat/converter/validate rs sr resource in rs ri Feat/converter : Validation de la présence de la ressource RS-SR dans le RS-RI lors de la conversion Apr 10, 2026
@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from ec50d2b to 72725d9 Compare April 15, 2026 10:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from 72725d9 to 7c9ca3b Compare April 15, 2026 11:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

Clemsazert
Clemsazert reviewed Apr 15, 2026
View reviewed changes
Comment thread converter/converter/cisu/resources_status/resources_status_converter.py
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

@issam71100 issam71100 force-pushed the feat/converter/validate-rs-sr-resource-in-rs-ri branch from df20481 to 478a2f2 Compare April 15, 2026 13:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

@issam71100 issam71100 merged commit f08c94a into converter/rc-ri-single-message Apr 16, 2026
2 checks passed
@issam71100 issam71100 deleted the feat/converter/validate-rs-sr-resource-in-rs-ri branch April 16, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Clemsazert Clemsazert Clemsazert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@issam71100 @Clemsazert